Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover: hover doesn't work because of missing value in variable #193

Open
aykut-rocks opened this issue Feb 15, 2024 · 0 comments
Open

hover: hover doesn't work because of missing value in variable #193

aykut-rocks opened this issue Feb 15, 2024 · 0 comments

Comments

@aykut-rocks
Copy link

aykut-rocks commented Feb 15, 2024

if i define

$media: (pointer fine);

.foo {
@include breakpoint($media) {
border: 0;
}
}

the result is:
@media (pointer: fine) { .foo { border: 0; } }

but if i define

$media: (hover hover);

.foo {
@include breakpoint($media) {
border: 0;
}
}

the result is
@media (: ) { .foo { border: 0; } }

As you see the query is empty, but the combination of pointer: fine and hover: hover is an important tool these days to identify non-touch devices, but this is not possible with breakpoint, so i'm not able to create a mixin and have to pollute our code with a lot of dublications, so i made the following changes locally:

the variable $breakpoint-string-features in the helpers.scss must be expanded with hover:

$breakpoint-string-features: 'orientation', 'scan', 'color', 'aspect-ratio', 'device-aspect-ratio', 'pointer',
'luminosity', 'hover';

could you please include this hover expansion to your codebase?

@aykut-rocks aykut-rocks changed the title hover: hover doesn't work hover: hover doesn't work because of missing value in variable Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant