-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Intl] Lockdown implementation #71
Comments
I don't think we need to complicate things by using libraries and just roll out our own basic solution. A folder with constants files based on language .i.e Then used within the app... I'm thinking the time spent next week on this should be to just work this kind of implementation and get rid of react-intl entirely. |
If we go this route, we'll have to roll out our own solution to format numbers, dates and time, pluralization, currency (not really applicable here). What are some of the pain points of react-intl that made you want to move away from it? Things do get a little hairy with a react navigation but if we were to do our own stylings in the future, we would end up with the same implementation in having to do provide our own components instead of a string. As for the form components we could pass a formatted message with id and defaultMessage to FormLabel. This would also make it easier for us since we don't have to manage a constants file and not worry about duplicates. Or if we only want to pass strings and not components, we could pass a primaryTextId
Then we'll define the default message in So if we don't need the support to format dates, number, currency, and maybe some pluralization, maybe we can roll out our own and manage a constants file for every copy in the app. |
My suggestion is to put this on the back burner for now. Almost everybody in the community communicates in English. The 2nd most spoken language I see is German and almost all germans speak perfect english so I don't think it'll be much of an issue. I would like us to focus on getting the alpha version of the app out and get users feedback as soon as possible. |
No description provided.
The text was updated successfully, but these errors were encountered: