From 0f186dbcc66aa027514ffb17342b25baf4c2cc50 Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Fri, 14 Jun 2024 11:45:37 +0200 Subject: [PATCH 1/6] initial removal of "specviz" references --- APE13.rst | 37 ++++++++----------------------------- 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/APE13.rst b/APE13.rst index 911d8619..ab0e3eb4 100644 --- a/APE13.rst +++ b/APE13.rst @@ -18,7 +18,7 @@ Abstract The goal of this APE is to coordinate and plan the development of spectroscopic software within the astropy project. The requirements for spectroscopic tools include handling and reducing observations, different types of analysis, and -visualization of spectra. The goal of this APE is to provide a framework that +supporting IO on data files used in the community. The goal of this APE is to provide a framework that different astronomy packages can use to coordinate the development of spectroscopic tools. The idea is a set of foundational packages that can then be extended to build other tools. As part of this coordination effort, this APE @@ -128,7 +128,7 @@ domain-specific classes are not defined in this APE; instead, the intent is for `Spectrum1D` to provide a starting point for such efforts, which will then develop as they are called for by the community. -The development outlined in this APE will consist of three packages: +The development outlined in this APE will consist of two packages: * `specutils `_. This will provide the basic interface classes (including the `Spectrum1D` object), as well as @@ -145,23 +145,12 @@ The development outlined in this APE will consist of three packages: This package will provide the tools to quickly be able to build specific instrument pipelines. -* `specviz`. This package will provide 1D spectrum visualization capabilities, - but is scoped to be focused primarily on that, and not arbitrarily complex - spectrum visualization (e.g., data cubes). Note that, unlike the above two, - this package should *not* be considered a toolbox that other tools should be - derived from. While other packages are welcome to use it, it is meant to - provide a critical piece of functionality, while acknowledging that - visualization, GUI code, and even personal taste are variable enough that - there is room for a few other visualization packages in the ecosystem. It - will, however, have a plugin architecture that may allow users/developers to - add to it. - In addition to the packages described above, there are a wide range of more domain-specific, experimental, or taste-specific packages that are likely to be desired in the field of astronomical spectroscopy. These packages can be developed as independent affiliated packages, and this APE encourages such development. However, the intent is for such packages to not *duplicate* -behavior in the foundational three packages described above. Because of the +behavior in the foundational packages described above. Because of the wide range of scientific use cases for spectra, it is understood that some level of duplication between affiliated packages is expected. E.g., multiple line-fitting packages may be reasonable because different science cases may be @@ -420,10 +409,10 @@ This should *not* be taken as an exhaustive list, however. Additional functionality that meets the above guidelines will be implemented or accepted via PRs to `specutils` if of sufficient general interest. -The next steps: specreduce and specviz --------------------------------------- -This APE is not intended to specify the full details of the ``specviz`` and -``specreduce`` packages. They will develop separately following the +The next steps: specreduce +-------------------------- +This APE is not intended to specify the full details of the +``specreduce`` package. It will develop separately following the standard process for developing astropy packages, but this section outlines *example* functionality expected for these packages. @@ -435,14 +424,6 @@ outlines *example* functionality expected for these packages. * Flux calibration of spectra * Integration with (but *not* duplication of) 2D image-level reduction steps from packages like `ccdproc `_ -``specviz``: -* Display a spectrum -* Explore the spectra by zooming in on features or moving to different areas. -* -* Do analysis like line flux measurements (using algorithms provided in `specutils`) or line fitting -* Overlay spectral line lists (including redshift offsets if relevant) - - Branches and pull requests -------------------------- @@ -457,9 +438,7 @@ github repository, and *part* of the `Spectrum1D` class in this APE has been implemented there, but will need to be completed if this APE is accepted. `specreduce `_ also has an implementation, which can be adapted to use the framework described -here. Similarly, visualization via the `specviz -`_ package will do the same. Of -course, other packages for spectroscopic analysis exist, and hopefully will +here. Of course, other packages for spectroscopic analysis exist, and hopefully will also be adapted to this framework in due time. From 038be9ccf309b5ce6b033939ce666207cdf09ae7 Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Fri, 14 Jun 2024 11:48:11 +0200 Subject: [PATCH 2/6] another implicit reference --- APE13.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/APE13.rst b/APE13.rst index ab0e3eb4..41486ac0 100644 --- a/APE13.rst +++ b/APE13.rst @@ -414,9 +414,7 @@ The next steps: specreduce This APE is not intended to specify the full details of the ``specreduce`` package. It will develop separately following the standard process for developing astropy packages, but this section -outlines *example* functionality expected for these packages. - -``specreduce``: +outlines *example* functionality expected for this package: * Methods for extracting a 1D spectrum from a 2D image of a dispersed spectrum, including boxcar and “optimal” extraction * Wavelength calibration From 17a9bf6d830a16cfd7742327417eee7af70ec3c3 Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Fri, 14 Jun 2024 14:53:52 +0200 Subject: [PATCH 3/6] add some metadata --- APE13.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/APE13.rst b/APE13.rst index 41486ac0..2281a7de 100644 --- a/APE13.rst +++ b/APE13.rst @@ -11,6 +11,9 @@ type: Process, Standard Track status: Accepted +revised-by: + +* Benjamin Weaver - 2024 June 30 - Spectrum visualization is now out-of-scope. Abstract -------- @@ -475,3 +478,7 @@ Decision rationale ------------------ There were extensive discussions with multiple stakeholders undertaken in the process of putting together this APE and it appears as though concensus has been reached. This APE was accepted on Dec 18, 2017. +Previous versions of this APE +----------------------------- + +* 2017-12-12 [`DOI `_] [`GitHub `_] From a77ce400125e08e3f473e1e7a24e303d0c5effce Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Fri, 19 Jul 2024 09:26:36 -0700 Subject: [PATCH 4/6] fix a typo --- APE13.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/APE13.rst b/APE13.rst index 2281a7de..a8d500ca 100644 --- a/APE13.rst +++ b/APE13.rst @@ -13,7 +13,7 @@ status: Accepted revised-by: -* Benjamin Weaver - 2024 June 30 - Spectrum visualization is now out-of-scope. +* Benjamin Weaver - 2024 July 19 - Spectrum visualization is now out-of-scope. Abstract -------- @@ -133,7 +133,7 @@ develop as they are called for by the community. The development outlined in this APE will consist of two packages: -* `specutils `_. This will provide the +* `specutils `_. This will provide the basic interface classes (including the `Spectrum1D` object), as well as *basic* analysis of spectroscopic data (which are enumerated in `Analysis tools to be included in specutils`_ below). This package is the primary From 2dbcd51efc58f118773fe5e01a09caebca40a0ae Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Mon, 22 Jul 2024 09:55:08 -0700 Subject: [PATCH 5/6] mention renamed spectrum class Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com> --- APE13.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/APE13.rst b/APE13.rst index a8d500ca..a489bf99 100644 --- a/APE13.rst +++ b/APE13.rst @@ -134,7 +134,7 @@ develop as they are called for by the community. The development outlined in this APE will consist of two packages: * `specutils `_. This will provide the - basic interface classes (including the `Spectrum1D` object), as well as + basic interface classes (including the `Spectrum1D` object, to be renamed `Spectrum` in specutils 2.0), as well as *basic* analysis of spectroscopic data (which are enumerated in `Analysis tools to be included in specutils`_ below). This package is the primary focus of this APE. From 1eac03cb9f2006ba1bc3e5895a9b58620dde79f0 Mon Sep 17 00:00:00 2001 From: Benjamin Alan Weaver Date: Wed, 4 Sep 2024 10:02:50 -0700 Subject: [PATCH 6/6] fix some typos --- APE13.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/APE13.rst b/APE13.rst index a489bf99..6537c349 100644 --- a/APE13.rst +++ b/APE13.rst @@ -111,7 +111,7 @@ The path forward ^^^^^^^^^^^^^^^^ This APE proposes a coordinated suite of packages for doing astronomical -spectroscopy in Python. It suggests a division of functionality into three +spectroscopy in Python. It suggests a division of functionality into two packages, then specifies in detail the structure and API of the core spectral object, `Spectrum1D`. @@ -139,7 +139,7 @@ The development outlined in this APE will consist of two packages: tools to be included in specutils`_ below). This package is the primary focus of this APE. -* `specreduce`. This will provide a standard toolbox for reducing spectra, +* `specreduce `_. This will provide a standard toolbox for reducing spectra, roughly akin to the IRAF “specred” functionality (although not necessarily *all* of those tasks, nor in a one-to-one manner). Note that this should *not* contain any instrument-specific code. Observatories or instruments are @@ -435,10 +435,10 @@ Implementation -------------- `specutils `_ already exists in its -github repository, and *part* of the `Spectrum1D` class in this APE has been -implemented there, but will need to be completed if this APE is accepted. -`specreduce `_ -also has an implementation, which can be adapted to use the framework described +github repository, and the `Spectrum1D` class in this APE has been +implemented there. Additional features are in development. +`specreduce `_ +also has an implementation, which has been adapted to use the framework described here. Of course, other packages for spectroscopic analysis exist, and hopefully will also be adapted to this framework in due time.