Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDLAudioManager not reaching RdMentalMap #30

Open
jgvictores opened this issue Feb 10, 2016 · 2 comments
Open

SDLAudioManager not reaching RdMentalMap #30

jgvictores opened this issue Feb 10, 2016 · 2 comments
Labels
bug

Comments

@jgvictores
Copy link
Member

OS: Ubuntu trusty
Branch: develop
SDLAudioManager not reaching RdMentalMap. SDLAudioManager used in RobotDevastation class, but is null in RdMentalMap.
David-Estevez added a commit that referenced this issue Mar 23, 2016
@David-Estevez
Fix issue #30, patch to try to solve issue #1
81d19f8
@David-Estevez
Copy link
Collaborator

For some reason, when the AudioManager was requested in MentalMap's constructor, the SDLAudioManager was not registered yet.

As a good practise from now on, it is advised to register the manager that is going to be requested in each constructor, except if several can be used (i.e. mockup, for testing purposes) and the default Manager is requested.

Fixed at 81d19f8

@jgvictores jgvictores reopened this Apr 6, 2018
@jgvictores
Copy link
Member Author

Reopening, as 81d19f8 was more of a work-around than a fix.

jgvictores added a commit that referenced this issue Apr 6, 2018
@jgvictores
Fixing cout beauty, comments for #30
e061fe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@David-Estevez @jgvictores