-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check modules that are enabled with cmake #21
Comments
@David-Estevez these combinations (I guess you refer to See also #95. |
In some old version of Robot Devastation, we had all different modules listed as ENABLE_X options, which didn't make sense because most of those modules were related and depended on each other, and that was the reason of this issue. The solution I had in mind was to allow disabling blocks of modules (i.e. allowing the user to disable the compilation of the My old self didn't know about that option, so the implementation I I was thinking then was to use simple if() cmake commands. |
Thanks for the clarification, @David-Estevez. I rewinded the repo to early 2015 and couldn't find those ENABLEs, so I concluded that such modularization never took place. We'l have to play with the currently available options:
I'm going to mark this issue as blocked (superseded?) by #95 since any planned/ongoing work would probably clash with the modifications introduced here. |
Note to self: use |
I'd like to apply roboticslab-uc3m/questions-and-answers#54 here, but we should first decide on the approach for modularization and mandatory/optional components, i.e. it wouldn't make sense to require SDL if I just want to compile the server app. |
Done at 45d01fa just to keep things tidy. We don't know yet how to proceed with the issue described here. |
Some modules cannot be disabled in cmake, as they are dependencies to other modules.
We should check these variables and enable only logic combinations (e.g. disabling tests, disabling main program, differenciating between tests and mockup tests, etc).
The text was updated successfully, but these errors were encountered: