Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fake PROPPATCH to make windows happy #52

Open
speq opened this issue Nov 12, 2019 · 9 comments
Open

Adding fake PROPPATCH to make windows happy #52

speq opened this issue Nov 12, 2019 · 9 comments

Comments

@speq
Copy link

speq commented Nov 12, 2019

Hi All,

I added a patch to response PROPPATCH for windows. Let dav-ext work with windows explorer.
Windows need LOCK and PROPPATCH to put a file.

proppatch.patch.gz

@divinity76
Copy link

IMO faking support is better than not supporting Windows at all,

but why do we need to fake it? is adding real support much more difficult or something? (i'm not complaining, i just honestly don't know the answer, i don't even know what PROPPATCH is supposed to do)

@divinity76
Copy link

divinity76 commented Nov 26, 2019

this is related to issue #18
(an issue that has been, in my opinion, erroneously closed)

@speq
Copy link
Author

speq commented Nov 30, 2019

Hi @divinity76,
I'm not expert of WebDAV and real support takes times.
It just worked well as a standalone web drive server for my personal use.

@divinity76
Copy link

i just skimmed through https://tools.ietf.org/html/rfc4918#section-9.2 , and concluded that adding proper PROPPATCH support is certainly non-trivial.

thanks for sharing!

love4taylor added a commit to love4taylor/nginx-dav-ext-module that referenced this issue Jan 9, 2020
@rozhuk-im
Copy link

For PROPPATCH there is a more simple way:

if ($request_method = PROPPATCH) { # Unsupported, allways return OK.
	add_header	Content-Type 'text/xml';
	return		207 '<?xml version="1.0"?><a:multistatus xmlns:a="DAV:"><a:response><a:propstat><a:status>HTTP/1.1 200 OK</a:status></a:propstat></a:response></a:multistatus>';
}

But for windows WebDAV clients you need more hacks: http://netlab.dhis.org/wiki/ru:software:nginx:webdav (see end of page - all in one hacks)

@Alfagun74
Copy link

thanks man @rozhuk-im

@aguaviva
Copy link

aguaviva commented Jan 16, 2022

Did anyone get this working with the above suggestions?

@rozhuk-im
Copy link

dgraziotin/docker-nginx-webdav-nononsense#8

@aguaviva
Copy link

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants