Disable url fragment and avoid anchor scroll #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wotta
suggested changes
Jun 19, 2019
| ## Installation | ||
|
|
||
| Install the package into a Laravel app that uses [Nova](https://nova.laravel.com) with Composer: | ||
|
|
||
| ```bash | ||
| composer require arsenaltech/nova-tab | ||
| composer require 64robots/nova-tab |
There was a problem hiding this comment.
please put this back the way it was since it doesn't comply with the changes you told you where making.
This PR disables url fragment in order to be compatible with Nova and its router.
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| Add the Tabs trait to your App\Nova\Resource class. | ||
|
|
||
| ```php | ||
| use Arsenaltech\NovaTab\Tabs; | ||
| use R64\NovaTab\Tabs; |
There was a problem hiding this comment.
Suggested change
| use R64\NovaTab\Tabs; | |
| use Arsenaltech\NovaTab\Tabs; |
| @@ -1,26 +1,21 @@ | |||
| # Laravel Nova Tab [](https://packagist.org/packages/arsenaltech/nova-tab) | |||
|
|
|||
| # Laravel Nova Tab | |||
There was a problem hiding this comment.
Suggested change
| # Laravel Nova Tab | |
| # Laravel Nova Tab [](https://packagist.org/packages/arsenaltech/nova-tab) |
| @@ -1,26 +1,21 @@ | |||
| # Laravel Nova Tab [](https://packagist.org/packages/arsenaltech/nova-tab) | |||
|
|
|||
| # Laravel Nova Tab | |||
|
|
|||
| Custom Nova field to render tabs | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
|  | |
|  | |
|  |
|
Sorry I did the pr hoping for a quick merge. But we needed all these changes in our fork for a client. Original pr was only the first commit. |
|
That means you still need to change this pr before actually being able to get the fix through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables url fragment in order to be compatible with Nova and its router.
Closes #13