-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page scrolling to anchor when content is too long #13
Comments
That's right, it is just default behavior. |
@shabbirbharmal -- Yes, but it should be disabled. Why did you close this? https://vuejs.org/v2/guide/events.html
|
Because that is the default behavior of tab component I am using and I didn't see any option to change it or make it configurable. Let me know if you think we are not on the same page with the issue you are facing. |
It doesn't need to be a configurable option. The page simply shouldn't move at all when you change tabs. Just like most other websites. A good example is github right here when you add a reply, there is a "Write" and "Preview" tab on the editor. The page doesn't scroll. If the page moves when users are clicking a tab, it's very disorienting and the first thing they will do is scroll back up. I'm not familiar enough with Vue or Nova to get this installed. Bust in native javascript or any other library it's usually a one liner added to the click event to disable the browsers default behavior. |
Is this what you're using? https://github.com/spatie/vue-tabs-component It doesn't happen in the demo on that website. Demo: http://vue-tabs-component.spatie.be/
|
I see what is happening here. URL fragment is conflicting with Nova's Vue router. Will have to disable URL fragment to fix this |
Awesome, hopefully it's not to difficult. |
I'm not sure if this is just on my end or not. This should be disabled though. There's no need to scroll the page to the anchor when switching tabs. This is just the default behavior when clicking links with anchors.
The text was updated successfully, but these errors were encountered: