Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extensive tests #4

Open
ariesclark opened this issue Aug 11, 2022 · 3 comments
Open

Add extensive tests #4

ariesclark opened this issue Aug 11, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@ariesclark
Copy link
Owner

The package doesn't currently have any tests, I'd like to ensure code changes doesn't cause regressions and break the publicly exposed apis.

@ariesclark ariesclark added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 11, 2022
@ariesclark ariesclark added this to the v1 milestone Aug 11, 2022
@rexfordessilfie
Copy link
Contributor

Hello @ariesclark, I came across this repository recently and would love to assist in setting up some testing for the project! Do you have a preference on what testing framework to use?

I am mostly familiar with Jest, I have used Ava recently, and Mocha as well.

@ariesclark
Copy link
Owner Author

Hello @ariesclark, I came across this repository recently and would love to assist in setting up some testing for the project! Do you have a preference on what testing framework to use?

I am mostly familiar with Jest, I have used Ava recently, and Mocha as well.

Currently, there are no tests in place and I am open to using any testing frameworks. However, if I had to choose, I would prefer Ava. You are welcome to submit a pull request, and if you are interested in contributing in the future, I will gladly grant you contributor access.

@rexfordessilfie
Copy link
Contributor

Hello @ariesclark, I came across this repository recently and would love to assist in setting up some testing for the project! Do you have a preference on what testing framework to use?
I am mostly familiar with Jest, I have used Ava recently, and Mocha as well.

Currently, there are no tests in place and I am open to using any testing frameworks. However, if I had to choose, I would prefer Ava. You are welcome to submit a pull request, and if you are interested in contributing in the future, I will gladly grant you contributor access.

That sounds perfect! I will submit a pull request with some initial tests and yes, I'd love to contribute where I can in the future. I have taken an interest in Typescript code generation and would love to learn more from this library and use it in projects. Thanks for working on it, and for your response. I hope to get back with a pull request soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants