Problem with TLS ingress

[Youpiiiii]

Describe the bug

Bad generation of ingress

Related helm chart

argo-cd

Helm chart version

7.6.8

To Reproduce

helm install argocd argo/argo-cd -f argo-cd/values.yaml --dry-run
With this values:

server:
  ingress:
    enabled: true
    tls: true

Generate this ingress:

# Source: argo-cd/templates/argocd-server/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: argocd-server
  namespace: "argocd"
  labels:
    helm.sh/chart: argo-cd-5.36.7
    app.kubernetes.io/name: argocd-server
    app.kubernetes.io/instance: argocd
    app.kubernetes.io/component: server
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: argocd
    app.kubernetes.io/version: v2.7.6
spec:
  rules:
    - http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: argocd-server
                port:
                  number: 80
  tls:
    true

Why tls: true ?

Expected behavior

# Source: argo-cd/templates/argocd-server/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: argocd-server
  namespace: "argocd"
  labels:
    helm.sh/chart: argo-cd-5.36.7
    app.kubernetes.io/name: argocd-server
    app.kubernetes.io/instance: argocd
    app.kubernetes.io/component: server
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: argocd
    app.kubernetes.io/version: v2.7.6
spec:
  rules:
    - http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: argocd-server
                port:
                  number: 80
  tls:
    - secretName: argocd-server-tls
      hosts:
      - argocd.example.com

Screenshots

No response

Additional context

No response

[mkilchhofer]

Are you sure? Your reprod steps are inconsistent. You are talking about helm chart version 7.6.8 and your rendered YAML says:

# ..
  labels:
    helm.sh/chart: argo-cd-5.36.7 # <- this means chart version 5.36.7
# ..

You need to update the Helm chart version to the latest (2 new Major versions) to use tls: true. The Helm chart version 5.36.x is using another structure:

argo-helm/charts/argo-cd/templates/argocd-server/ingress.yaml

Lines 86 to 89 in 172ce60

	{{- with .Values.server.ingress.tls }}
	tls:
	{{- toYaml . | nindent 4 }}
	{{- end -}}

---

Update: Ah maybe you are using an old repo cache as your command does not specify a version excplicitly

- helm install argocd argo/argo-cd -f argo-cd/values.yaml --dry-run
+ helm install argocd argo/argo-cd -f argo-cd/values.yaml --version 7.6.8 --dry-run

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.