From 7a9a934ae38324f11d7d3be580a3ec329a73f96f Mon Sep 17 00:00:00 2001 From: codefiles <11915375+codefiles@users.noreply.github.com> Date: Thu, 28 Sep 2023 18:29:54 -0400 Subject: [PATCH] Refactor `_add_efistub_bootloader()` use cmd list (#2127) --- archinstall/lib/installer.py | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/archinstall/lib/installer.py b/archinstall/lib/installer.py index 5d1bb7dc79..f0df732278 100644 --- a/archinstall/lib/installer.py +++ b/archinstall/lib/installer.py @@ -1076,23 +1076,22 @@ def _add_efistub_bootloader( for kernel in self.kernels: # Setup the firmware entry - label = f'Arch Linux ({kernel})' - loader = f"/vmlinuz-{kernel}" - cmdline = [ *microcode, f"initrd=\\initramfs-{kernel}.img", *kernel_parameters, ] - cmd = f'efibootmgr ' \ - f'--disk {parent_dev_path} ' \ - f'--part {boot_partition.partn} ' \ - f'--create ' \ - f'--label "{label}" ' \ - f'--loader {loader} ' \ - f'--unicode \'{" ".join(cmdline)}\' ' \ - f'--verbose' + cmd = [ + 'efibootmgr', + '--disk', str(parent_dev_path), + '--part', str(boot_partition.partn), + '--create', + '--label', f'Arch Linux ({kernel})', + '--loader', f"/vmlinuz-{kernel}", + '--unicode', ' '.join(cmdline), + '--verbose' + ] SysCommand(cmd)