Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trigger category from locales #11

Open
t-kelly opened this issue Jan 18, 2024 · 7 comments · Fixed by #20
Open

Remove trigger category from locales #11

t-kelly opened this issue Jan 18, 2024 · 7 comments · Fixed by #20
Assignees

Comments

@t-kelly
Copy link
Member

t-kelly commented Jan 18, 2024

This is specific functionality tied to the size chart feature, which needs to be triggered based on a variant option id that changes based on the language that is set. Ideally we could handle this without locales?

@matoululu
Copy link
Contributor

matoululu commented Jan 23, 2024

Hey @t-kelly -- totally!

One route that comes to mind would be to have a text field in the size chart block settings which can be used to reference any variant title (color, size etc) which would also add flexibility to that block.

That being said we would obviously want to rename 'Size chart' since it wouldn't be a size chart specifically anymore.

If we dig this route I'll need to pick @wik-swiecicka & @charlie-quinn brain for a new name for this block 🤔

1 thing to note though is any references in documentation would also need to changed.

Thoughts?

@wik-swiecicka
Copy link
Member

Can we keep the size chart block for better discoverability and create a duplicate with a more generic name @matoululu

@matoululu
Copy link
Contributor

@wik-swiecicka totally a possibility

Brings up an interesting point I hadn't thought of regarding a generic popup trigger is we'd need to think of a way for the trigger text to be localized too (ex: the 'Size chart' trigger that opens up the tooltip) -- perhaps it'll be best to start with just size chart while I consider our options there 😄

@charlie-quinn
Copy link
Contributor

If we went the adding a new block route...

Some ideas:

  • "Content modal"
  • "Page modal" (I know this might sound silly but I'm adding it anyway!)
  • ✨ Enhancement: the ability to add an icon for more flexibility

@charlie-quinn charlie-quinn removed their assignment Jan 24, 2024
@matoululu
Copy link
Contributor

matoululu commented Jan 24, 2024

Thanks @wik-swiecicka and @charlie-quinn

all great points! I do like the overall feeling of enhancing this block, given this issue is related to the locales specifically i'm realizing that I should create a new enhancement issue for this elsewhere. In the meanwhile I had another thought on an effective way to remove this locale without interruption or much rework 😄 thank you!

@matoululu
Copy link
Contributor

A note here, the trigger for Color swatches still seems important as we don't have a great way to check for the word "Color" in multiple languages otherwise

@t-kelly
Copy link
Member Author

t-kelly commented Feb 13, 2024

Re-opening because its still not fixed 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants