-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trigger category from locales #11
Comments
Hey @t-kelly -- totally! One route that comes to mind would be to have a text field in the size chart block settings which can be used to reference any variant title (color, size etc) which would also add flexibility to that block. That being said we would obviously want to rename 'Size chart' since it wouldn't be a size chart specifically anymore. If we dig this route I'll need to pick @wik-swiecicka & @charlie-quinn brain for a new name for this block 🤔 1 thing to note though is any references in documentation would also need to changed. Thoughts? |
Can we keep the size chart block for better discoverability and create a duplicate with a more generic name @matoululu |
@wik-swiecicka totally a possibility Brings up an interesting point I hadn't thought of regarding a generic popup trigger is we'd need to think of a way for the trigger text to be localized too (ex: the 'Size chart' trigger that opens up the tooltip) -- perhaps it'll be best to start with just size chart while I consider our options there 😄 |
If we went the adding a new block route... Some ideas:
|
Thanks @wik-swiecicka and @charlie-quinn all great points! I do like the overall feeling of enhancing this block, given this issue is related to the locales specifically i'm realizing that I should create a new enhancement issue for this elsewhere. In the meanwhile I had another thought on an effective way to remove this locale without interruption or much rework 😄 thank you! |
A note here, the trigger for Color swatches still seems important as we don't have a great way to check for the word "Color" in multiple languages otherwise |
Re-opening because its still not fixed 100% |
This is specific functionality tied to the size chart feature, which needs to be triggered based on a variant option id that changes based on the language that is set. Ideally we could handle this without locales?
The text was updated successfully, but these errors were encountered: