Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask displays "unknown method" in the confirmation form. #227

Open
Chralu opened this issue Dec 5, 2024 · 1 comment
Open

Metamask displays "unknown method" in the confirmation form. #227

Chralu opened this issue Dec 5, 2024 · 1 comment
Labels
external-contribution Contribution by non core team standby

Comments

@Chralu
Copy link
Collaborator

Chralu commented Dec 5, 2024

Describe the problem you discovered

When Metamask tries to call a smart contract function, the confirmation form shows a badge "unknown method".
Image

This is not reassuring for the user.

Describe the solution you'd like

Solutions to explore :

  • send the ABI to MM ...
@Chralu Chralu added the bug Something isn't working label Dec 5, 2024
@redDwarf03
Copy link
Member

redDwarf03 commented Dec 5, 2024

Bug from MM Mobile:
MetaMask/metamask-mobile#5567
MetaMask/metamask-mobile#7199
MetaMask/metamask-mobile#5929 (comment)

In the bridge code, we put abi in WriteContractParameters

return aedappfm.Result.guard(() async {
      
      final contractAbi = await loadAbi(
        contractNamePoolBase,
      );

        txAddress = await writeContractWithErrorManagement(
          parameters: wagmi.WriteContractParameters.eip1559(
            abi: contractAbi,
            address: poolAddress,
            functionName: 'mintHTLC',
            args: [
              hash.toBytes,
              scaledAmount,
            ],
            value: isWrapped == false ? scaledAmount : null,
          ),
          fromMethod: 'EVMLP - deployChargeableHTLC',
          ref: ref,
          evmBridgeProcess: EVMBridgeProcess.bridge,
        );

    

@redDwarf03 redDwarf03 added external-contribution Contribution by non core team standby and removed bug Something isn't working labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution Contribution by non core team standby
Projects
None yet
Development

No branches or pull requests

2 participants