Feature/handle geopatch updates in notifier #1620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1588) * add stamp.genesis_address * migration: add genesis to io * code_change * add genesis to graphql * add genesis to explorer * add genesis column to transactions list * set the genesis before decoding columns * code_change fix * remove opts from deserialize * add missing aliases * update graphql desc * Add genesis address only if requested * Hide genesis address in mobile view --------- Co-authored-by: Neylix <[email protected]>
wassimans
force-pushed
the
feature/handle-geopatch-updates-in-notifier
branch
from
07a79d4 to
f1c4300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the Notifier module to align with the updated topology change handling GeoPatch updates. The changes include:
Refactor Notifier Logic:
• Removed dependency on unavailable_nodes for election and topology change calculations.
• Simplified logic to work exclusively with prev_available_nodes and new_available_nodes, reflecting the current architecture needs.
Enhance GeoPatch Handling:
• Triggered a systematic Notifier process when a GeoPatch update occurs, ensuring consistency in storage elections and data distribution.
This enhancement resolves outdated logic in the Notifier module and addresses potential inconsistencies caused by GeoPatch updates.
Fixes #1619
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit Tests:
• Refactored existing unit tests to align with the new Notifier logic.
Checklist: