Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geopatch in node transaction #1576

Open
Neylix opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1605
Open

Add Geopatch in node transaction #1576

Neylix opened this issue Oct 18, 2024 · 0 comments · May be fixed by #1605
Assignees
Labels
election enhancements P2P Involve P2P networking

Comments

@Neylix
Copy link
Member

Neylix commented Oct 18, 2024

Is your feature request related to a problem?

The election of storage nodes and validation nodes is based on the geopatch of the current authorized nodes.
This geopatch is calculated from the IP address of the nodes, but it is calculated locally and based on MMDB2 database.

For verification purpose we need to remake the election of an old transaction at the time it was validated.
While we can technically retrieve the geopatch of a node at a specific time it could not work if the MMDB2 database is updated

Describe the solution you'd like

When a node join the network or send a node update transaction, it could include the geopatch it calculated locally and so validation nodes could ensure the geopatch is valid.
Then instead of relying to a local calculated geopatch, the local p2p view could be filled with the validated geopatch of the node transaction.
Hence even if the MMDB2 database is updated we could easily retrieve the geopatch of a node at a specific date through it's transaction chain.

Also notice that an update of the geopatch will update the election of storage nodes and so nodes need to reorganize their data using the Notifier.

Additional context

During the deployment of the release containing this update, a migration task needs to be runned to create a new node transaction for each node to setup their geopatch.

Epic

No response

@Neylix Neylix added election enhancements P2P Involve P2P networking labels Oct 18, 2024
@Neylix Neylix added this to the BLS prerequisites milestone Oct 18, 2024
@wassimans wassimans self-assigned this Nov 6, 2024
@wassimans wassimans linked a pull request Nov 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
election enhancements P2P Involve P2P networking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants