Filter the new users count to not include future days #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-20 13:03:35 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-20 13:03:35 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-20 13:03:33 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-12-20 13:03:32 CET |
ItzNotABug
reviewed
Dec 20, 2024
src/routes/(console)/organization-[organization]/usage/[[invoice]]/+page.svelte
Outdated
Show resolved
Hide resolved
ItzNotABug
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before:
After:
Usage data comes from the API as newly added users per day. The graph is being built by subtracting these newly added users from the total amount. The API returns future dates (with 0 new users added on those day, because they are in the future). So the graph showed days in the future. This is now fixed!
Have you read the Contributing Guidelines on issues?
✅