Fix flaky bleve server test #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timburks
changed the title
theganyo
approved these changes
Jul 24, 2023
|
Yes, I expect this is more of a network and server timeout... and having no port in existence leads to a quick and painless death. And while 1s is probably overkill and some kind of backoff retry would be the best option, I see no reason to worry about any of that here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating #218... tests were failing when
DialTimeout()returns immediately with "connection refused". Increasing the timeout didn't help, and reviewing the timestamps in the log file, it was clear that the failure was immediate -- I'm guessing that the goroutine running the server hadn't even started, so when the connection was attempted it failed immediately because there was nothing to connect with. I suspect thatDialTimeout()wasn't written for cases where the server hadn't been started yet but was instead intended to handle slow network connections and slow server responses.Adding an explicit sleep allowed the test to pass on all 3 of 3 attempts (it was failing 1/2 to 2/3 of the time previously).