Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Init before AddInstance while backing up #480

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat: add Init before AddInstance while backing up #480

merged 1 commit into from
Dec 15, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Dec 15, 2023 •
edited
Loading

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Using gs_probackup init to init dn-backup-path before AddInstance

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added the pitr solutions of pitr label Dec 15, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mlycore mlycore added this to the 0.4.0 milestone Dec 15, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 923 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (8cb6480) 36.81%.
Report is 240 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/agent/internal/pkg/opengauss.go 6.52% 86 Missing ⚠️
pitr/cli/internal/cmd/delete.go 67.45% 43 Missing and 12 partials ⚠️
pitr/cli/pkg/prettyoutput/progress.go 8.51% 43 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 11.11% 37 Missing and 3 partials ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/cmd/backup.go 74.78% 28 Missing and 2 partials ⚠️
pitr/cli/internal/cmd/common.go 77.77% 16 Missing and 8 partials ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   39.71%   36.81%   -2.90%     
==========================================
  Files          51       60       +9     
  Lines        6083     6945     +862     
==========================================
+ Hits         2416     2557     +141     
- Misses       3448     4142     +694     
- Partials      219      246      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlycore mlycore merged commit 7600684 into apache:main Dec 15, 2023
7 checks passed
@mlycore mlycore deleted the fix-init branch December 15, 2023 10:06
@mlycore mlycore mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taojintianxia taojintianxia taojintianxia approved these changes

Assignees
No one assigned
Labels
pitr solutions of pitr type: feature
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mlycore @codecov-commenter @taojintianxia