Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor to disk space error while backing up #474

Merged
merged 9 commits into from
Nov 27, 2023
Merged

refactor: refactor to disk space error while backing up #474

merged 9 commits into from
Nov 27, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 27, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the pitr solutions of pitr label Nov 27, 2023
@mlycore
fix: remove comments
3e5604f 
Signed-off-by: mlycore <[email protected]>
@mlycore mlycore added this to the 0.4.0 milestone Nov 27, 2023
@mlycore
chore: add golint comment
2678604 
Signed-off-by: mlycore <[email protected]>
@mlycore
fix: fix test
edfade4 
Signed-off-by: mlycore <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 920 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (edfade4) 36.83%.
Report is 226 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/agent/internal/pkg/opengauss.go 6.52% 86 Missing ⚠️
pitr/cli/internal/cmd/delete.go 67.45% 43 Missing and 12 partials ⚠️
pitr/cli/pkg/prettyoutput/progress.go 8.51% 43 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 11.11% 37 Missing and 3 partials ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/cmd/backup.go 74.78% 28 Missing and 2 partials ⚠️
pitr/cli/internal/cmd/common.go 77.77% 16 Missing and 8 partials ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   39.71%   36.83%   -2.89%     
==========================================
  Files          51       60       +9     
  Lines        6083     6942     +859     
==========================================
+ Hits         2416     2557     +141     
- Misses       3448     4139     +691     
- Partials      219      246      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaojinchao95 zhaojinchao95 merged commit 31e7cbc into apache:main Nov 27, 2023
8 checks passed
@mlycore mlycore deleted the test branch November 27, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
pitr solutions of pitr type: refactor
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mlycore @codecov-commenter @strongduanmu @zhaojinchao95