Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow fix for Java 1.8? #13064

Closed
AngledLuffa opened this issue Jan 31, 2024 · 2 comments
Closed

Stack overflow fix for Java 1.8? #13064

AngledLuffa opened this issue Jan 31, 2024 · 2 comments

Comments

@AngledLuffa
Copy link

Hi,

I am the primary maintainer of Stanford CoreNLP. We use the Lucene libraries for various things in our software.

I found that there's a fix for a stack overflow error in recent versions of Lucene:

#12462

This was in response to the following issue a user raised on our software:

stanfordnlp/CoreNLP#1408

However, when I went to update the Lucene libraries we depend on, it turns out the latest releases target Java 11. I don't suppose there's a release of Lucene which targets 8? We have kept our software compatible with Java 8 for a while, although we're aware that eventually we'll want to move on to newer versions.

Thanks in advance

@dweiss
Copy link
Contributor

dweiss commented Jan 31, 2024

Your best bet would be to bump the minimum requirements to a more recent Java version and use a more recent Lucene release. There are benefits reaching beyond just that particular bug - new features, new codecs, faster searches.

Lucene 8 does occasionally receive patches in the joint Lucene/Solr repository, here:
https://github.com/apache/lucene-solr/commits/branch_8_11/

I don't think there'll be a lot of interest to backport larger things to that branch though.

@AngledLuffa
Copy link
Author

Yeah, it's probably about time to move on from 8. Will need to give a heads up to our userbase, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants