Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Enhanced syntax highlighting #4737

Closed
nadment opened this issue Dec 22, 2024 · 0 comments · Fixed by #4738
Closed

[Task]: Enhanced syntax highlighting #4737

nadment opened this issue Dec 22, 2024 · 0 comments · Fixed by #4738
Assignees
@nadment
Labels
Hop Gui P3 Nice to have task
Milestone
2.12

Comments

@nadment
Copy link
Contributor

nadment commented Dec 22, 2024

What needs to happen?

Addition of a StyleAttribute for highlighting with color and style (NORMAL,ITALIC,BOLD)
Added coloring of symbol syntax
image

Corrected highlighting of JavaScript function names
Replaced synchronized Vector and Hashtable classes
Changed colors for dark mode
Code cleanup

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui
@nadment nadment self-assigned this Dec 22, 2024
@github-actions github-actions bot added the P3 Nice to have label Dec 22, 2024
nadment added a commit to nadment/hop that referenced this issue Dec 22, 2024
@nadment
Enhanced syntax highlighting apache#4737
bd5b844 
- Add StyleAttribute to highlight with color and style
(NORMAL,ITALIC,BOLD)
- Add symbol syntax coloring
- Fix JavaScript function names highlight
- Replace synchronized Vector and Hashtable class
- Change colors for dark mode
- Fix look UserDefinedJavaClassDialog
- Code cleanup
@nadment nadment linked a pull request Dec 22, 2024 that will close this issue
Enhanced syntax highlighting #4737 #4738
Merged
hansva pushed a commit to nadment/hop that referenced this issue Dec 24, 2024
@nadment @hansva
Enhanced syntax highlighting apache#4737
b3925a3 
- Add StyleAttribute to highlight with color and style
(NORMAL,ITALIC,BOLD)
- Add symbol syntax coloring
- Fix JavaScript function names highlight
- Replace synchronized Vector and Hashtable class
- Change colors for dark mode
- Fix look UserDefinedJavaClassDialog
- Code cleanup
hansva added a commit to nadment/hop that referenced this issue Dec 24, 2024
@hansva
fix rebase, apache#4737
01ebf38
hansva added a commit that referenced this issue Dec 24, 2024
@hansva
Merge pull request #4738 from nadment/4737
17c3a0c 
Enhanced syntax highlighting #4737
@hansva hansva added this to the 2.12 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
Hop Gui P3 Nice to have task
Projects
None yet
Milestone
2.12
Development

Successfully merging a pull request may close this issue.

Enhanced syntax highlighting #4737 nadment/hop
2 participants
@hansva @nadment