Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ways to verify the integrity of the build artifacts #3924

Closed
5 tasks
grahamc opened this issue Feb 10, 2017 · 6 comments
Closed
5 tasks

Provide ways to verify the integrity of the build artifacts #3924

grahamc opened this issue Feb 10, 2017 · 6 comments

Comments

@grahamc
Copy link

grahamc commented Feb 10, 2017

Sorry for the wonky issue title, but there are a few issues all in one. In short, I'm working to package Druid for work. As part of that, I noticed a few things:

First I looked for a signature files (.asc) to verify the binaries against a published key.

This can be fairly tricky to implement and manage, so I then looked around for published file hashes (sha256/512 preferable, md5 isn't sufficient for this any longer) that I could use to assert I received the correct bits. Unfortunately, these don't seem to be published either.

I then visited the GitHub project releases hoping to find the artifacts in a place I could download over HTTPs, but no luck: we'd have to build from source.


I noted both the CDN and the website are served over plain HTTP. With the website on GitHub, it would be possible to verify the hash is correct by checking the source and using the hash to verify the http-served artifact.

In the mean time, I am planning on doing a sort of "Trust On First Use" verification, by hashing the first time, and then expecting the release file's hash to match from then on out.


In summary, a potential to-do list here would be:

  • stopgap: serve build artifacts through GitHub releases
  • provide SHA256 / SHA512 hashes on the website
  • serve the website over HTTPS
  • serve the CDN over HTTPS
  • bonus points generate PGP signature files (.asc) for the artifacts

recommended labels: Improvement, Operations

@gianm
Copy link
Contributor

gianm commented Feb 13, 2017

Fwiw, the Imply distro (https://imply.io/download) is served over HTTPS and we publish sha256 hashes over HTTPS as well. This issue for druid-io.github.com is about trying to bring some of that same love to community Druid: druid-io/druid-io.github.io#372.

@drcrallen
Copy link
Contributor

I'm curious if AWS codebuild can do this easily.

@elukey
Copy link

elukey commented May 14, 2018

Providing a sha256 hash to the last druid releases should be fairly easy in https://github.com/druid-io/druid/releases. It will take no time for the developers and it should give some relief to whoever wants to trust the binaries downloaded by static.druid.io.

@stale
Copy link

stale bot commented Jun 21, 2019

This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Jun 21, 2019
@stale
Copy link

stale bot commented Jul 5, 2019

This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

@stale stale bot closed this as completed Jul 5, 2019
@elukey
Copy link

elukey commented Jul 5, 2019

Please re-open this task, it shouldn't be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants