Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out tests in aggregate.slt #13723

Open
Rachelint opened this issue Dec 10, 2024 · 2 comments
Open

Sort out tests in aggregate.slt #13723

Rachelint opened this issue Dec 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Rachelint
Copy link
Contributor

Is your feature request related to a problem or challenge?

I found tests in aggregate.slt a bit messy and the file is too big(6088 rows)... when I try add more tests of median for #13681

Maybe we should split and sort out such tests to make it clearer.

Describe the solution you'd like

I think #12525 is a good example.

And maybe we can do something like it. We can split the tests into multiple test files, and each file only contains testcases for a special aggregation function:

  • Current
aggregate.slt
  • After sorting out
aggregate
  init.slt.part
  min_max.slt
  median.slt
  ...

Describe alternatives you've considered

No response

Additional context

No response

@Rachelint Rachelint added the enhancement New feature or request label Dec 10, 2024
@Omega359
Copy link
Contributor

I noted this in #13470 (comment) ... I think a bunch of those test files could be refactored and reorganized.

@Rachelint
Copy link
Contributor Author

I noted this in #13470 (comment) ... I think a bunch of those test files could be refactored and reorganized.

It may be great if can refactor other test files messy like it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants