Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btrie disable flag #33457

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

rohitsinha54
Copy link
Contributor

Add a flag to disable user bounded trie.

This PR is based on top of #33385 (so majority of commit from that branch except the last one). Will be rebased and submitted after the other one is submitted.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@rohitsinha54
Copy link
Contributor Author

R: @robertwb

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (d9092a5) to head (46ff528).
Report is 75 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #33457      +/-   ##
============================================
+ Coverage     57.40%   59.00%   +1.60%     
- Complexity     1475     3185    +1710     
============================================
  Files           973     1139     +166     
  Lines        154794   175426   +20632     
  Branches       1076     3368    +2292     
============================================
+ Hits          88854   103511   +14657     
- Misses        63737    68566    +4829     
- Partials       2203     3349    +1146     
Flag Coverage Δ
java 70.34% <ø> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant