Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws v1 from infrastructure #33455

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

damccorm
Copy link
Contributor

Part of #33430 to remove AWS v1 IOs entirely. This removes the v1 precommits and removes them from our infra used for load testing


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

Precommit failures are unrelated, retrying but not blocking on them

@damccorm
Copy link
Contributor Author

damccorm commented Dec 27, 2024

@aromanenko-dev here is another PR for aws v1 ios if you are around (I'll let the bot assign reviewers in case you are unavailable for the holidays 😄)

@damccorm damccorm marked this pull request as ready for review December 27, 2024 17:24
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label build.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.43%. Comparing base (5944a30) to head (3a901de).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33455   +/-   ##
=========================================
  Coverage     57.43%   57.43%           
  Complexity     1474     1474           
=========================================
  Files           979      979           
  Lines        155295   155295           
  Branches       1076     1076           
=========================================
  Hits          89201    89201           
  Misses        63882    63882           
  Partials       2212     2212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a cleanup somewhere

@damccorm damccorm merged commit 97c4134 into master Dec 30, 2024
22 checks passed
@damccorm damccorm deleted the users/damccorm/aws-v1-removal-1 branch December 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants