From 76d04a8fa48c92185cb3681c906cdd6e06dca391 Mon Sep 17 00:00:00 2001 From: SeeRightThroughMe <33134893+SeeRightThroughMe@users.noreply.github.com> Date: Mon, 10 Jun 2024 21:00:04 +0100 Subject: [PATCH 1/3] Added panic message to docs. (#5857) --- arrow-schema/src/schema.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arrow-schema/src/schema.rs b/arrow-schema/src/schema.rs index ede158fcf248..3bb076aa54b0 100644 --- a/arrow-schema/src/schema.rs +++ b/arrow-schema/src/schema.rs @@ -331,6 +331,10 @@ impl Schema { /// Returns an immutable reference of a specific [`Field`] instance selected using an /// offset within the internal `fields` vector. + /// + /// # Panics + /// + /// Panics if index out of bounds pub fn field(&self, i: usize) -> &Field { &self.fields[i] } From 7f66b77af945680c12e13392936013bdc68541df Mon Sep 17 00:00:00 2001 From: Eduard Karacharov Date: Tue, 11 Jun 2024 15:25:23 +0300 Subject: [PATCH 2/3] fix: msrv CI for object_store (#5866) * fix: msrv CI for object_store * fixed url crate version --- .github/workflows/rust.yml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index d8d892ea9404..a1644ee49b8d 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -119,17 +119,20 @@ jobs: run: cargo update -p ahash --precise 0.8.7 - name: Check arrow working-directory: arrow - run: cargo msrv verify + run: cargo msrv --log-target stdout verify - name: Check parquet working-directory: parquet - run: cargo msrv verify + run: cargo msrv --log-target stdout verify - name: Check arrow-flight working-directory: arrow-flight - run: cargo msrv verify + run: cargo msrv --log-target stdout verify - name: Downgrade object_store dependencies working-directory: object_store - # Necessary because 1.30.0 updates MSRV to 1.63 - run: cargo update -p tokio --precise 1.29.1 + # Necessary because tokio 1.30.0 updates MSRV to 1.63 + # and url 2.5.1, updates to 1.67 + run: | + cargo update -p tokio --precise 1.29.1 + cargo update -p url --precise 2.5.0 - name: Check object_store working-directory: object_store - run: cargo msrv verify + run: cargo msrv --log-target stdout verify From 298bf481adf898ece699fda25cb61191d7bfb29c Mon Sep 17 00:00:00 2001 From: Val Lorentz Date: Tue, 11 Jun 2024 14:26:55 +0200 Subject: [PATCH 3/3] parquet: Fix warning about unused import (#5865) --- parquet/src/arrow/array_reader/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/parquet/src/arrow/array_reader/mod.rs b/parquet/src/arrow/array_reader/mod.rs index f662156543ea..8febe41e6886 100644 --- a/parquet/src/arrow/array_reader/mod.rs +++ b/parquet/src/arrow/array_reader/mod.rs @@ -46,6 +46,7 @@ mod test_util; pub use builder::build_array_reader; pub use byte_array::make_byte_array_reader; +#[allow(unused_imports)] // Only used for benchmarks pub use byte_array::make_byte_view_array_reader; pub use byte_array_dictionary::make_byte_array_dictionary_reader; #[allow(unused_imports)] // Only used for benchmarks