lexer: add floats #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good start, but it misses Next step would be to implement them for generators, for JS and C it's extremely easy. For QBE it requires a bit more work to add float instructions and use them in binops |
YerinAlexey
reviewed
Oct 7, 2021
| @@ -131,6 +131,7 @@ pub enum TokenKind { | |||
| #[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord)] | |||
| pub enum Value { | |||
| Int, | |||
| Float, | |||
There was a problem hiding this comment.
Maybe we should keep floats and integers inside Value like we do with strings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Description
Adds the
floatdatatype.ToDo