Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Question on adam.py #2

Open
btahir opened this issue Apr 19, 2019 · 1 comment
Open

Quick Question on adam.py #2

btahir opened this issue Apr 19, 2019 · 1 comment

Comments

@btahir
Copy link

btahir commented Apr 19, 2019

Awesome work! The adam.py implementation is very useful! I just had a quick question about:

alpha_t = tf.sqrt(1 - beta2_power) / (1 - beta1_power)

What does this achieve? Wouldn't the original Adam implementation be?

var - lr * m_t / (tf.sqrt(v_t) + eps)

rather than

var - lr * (m_t*alpha_t) / (tf.sqrt(v_t) + eps)

Are you adding weight decay with alpha_t maybe?

@btahir btahir changed the title Quick QUestion on Adam.py Quick Question on adam.py Apr 19, 2019
@angetato
Copy link
Owner

Hello @btahir,
I know my answer is late but for those with the same question here is the answer :
In the original paper, see algorithm 1, they use
equation
instead of m_t (same for v_t) to compute the update. Thus :
equation
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants