Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

About a dozen files missing end-of-file ("trailing") newlines #140

Open
ethanherbertson opened this issue Apr 20, 2018 · 0 comments
Open

Comments

@ethanherbertson
Copy link

A number of source files in this project are missing trailing newlines. It's obviously not a BIG deal, but failing to include trailing newlines can break all kinds of command-line tools.

→ find -type f -print0 | xargs -0 -L1 bash -c 'test "$(tail -c 1 "$0")" && echo "No new line at end of $0"'
No new line at end of ./app/public/auth/forgot/forgotPassword.component.ts
No new line at end of ./app/public/auth/resend/resendCode.component.ts
No new line at end of ./app/secure/landing/secureHome.css
No new line at end of ./app/service/s3.service.ts
No new line at end of ./app/service/user-parameters.service.ts
No new line at end of ./assets/css/bootstrap-theme.min.css
No new line at end of ./assets/css/bootstrap.min.css
No new line at end of ./assets/css/sb-admin-2.min.css
No new line at end of ./assets/fonts/fontawesome-webfont.svg
No new line at end of ./assets/fonts/fontawesome-webfont.woff2
No new line at end of ./assets/img/intro-bg.jpg
No new line at end of ./assets/ui-js/bootstrap.min.js
No new line at end of ./assets/ui-js/metisMenu.min.js
No new line at end of ./assets/ui-js/sb-admin-2.min.js
No new line at end of ./polyfills.ts
No new line at end of ./styles.css

"Binary" files like svg, jpg, and woff2 aren't really concerns, but all "code" files should end in a newline, basically without exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant