Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The spotlight is lost if user scrolls the page #3

Open
alvaromontoro opened this issue Aug 19, 2018 · 2 comments
Open

The spotlight is lost if user scrolls the page #3

alvaromontoro opened this issue Aug 19, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@alvaromontoro
Copy link
Owner

SpotlighJS was designed for an unchangeable/unscrollable viewport. If the plugin is used on a regular web page and the user scrolls, the spotlight is lost. It would be nice if the spotlight never disappears from the current viewport.

@alvaromontoro alvaromontoro added the enhancement New feature or request label Aug 19, 2018
@alvaromontoro alvaromontoro added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 3, 2018
@dulcetti
Copy link
Contributor

dulcetti commented Oct 5, 2018

Hi @alvaromontoro. Can I take this too? What do you think if on user start the Spotlight, the scrolling turn off, and if he exit of Spotlight, the scrolling come back?

@alvaromontoro
Copy link
Owner Author

@dulcetti Of course. I was thinking about doing something like adding overflow:hidden to the html/body and readjusting the scroll so the user didn't notice a jump when the animation started or ended... but it may be overcomplicating things. Any suggestion is welcome.

@dulcetti dulcetti mentioned this issue Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants