Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorize the different skins #76

Open
allan-simon opened this issue Jul 5, 2013 · 2 comments
Open

factorize the different skins #76

allan-simon opened this issue Jul 5, 2013 · 2 comments

Comments

@allan-simon
Copy link
Owner

for the moment the two skins "tatoeba" and "responsive" have a LOT in common, it would be better to not have to stupidly copy/paste code everytime
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 started to create a 'commons skin' that will contain the defau…
0aba578 
…lt code for skins, re #72 now the tatoeba skin also has a working search/simple page
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 factorized search/result
b943bb6
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 factorized the view in media/
d51feb0
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 refactored all the articles/ pages , still need to update the …
f75cd91 
…javascript part of tatoeba skins
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 factorized history/ pages
24e7b72
allan-simon added a commit that referenced this issue Jul 5, 2013
@allan-simon
re #76 all the templates are now factorized, we're only missing code …
8270529 
…modification to share css/img/js between skins
@allan-simon
Copy link
Owner Author

when we serve the assets through a static server the extra /css /img and /js added by the commons/master.tmpl layout is not what we want

@allan-simon allan-simon reopened this Jul 14, 2013
@allan-simon
Copy link
Owner Author

adding a new "view" does correctly generate the common_view and view inherit from common_view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@allan-simon