Letter shaping not working almost on every terminal emulator

[LinArcX]

Hi. and thank you so much for this great repository.
I compiled neatvi with default settings. But i realized that farsi characters shaping only works in st terminal emulator:

I've tested with tilda, tilix, xfce4-terminal. But shaping characters failed in all of them.

[aligrudi]

LinArcX <[email protected]> wrote:

Hi. and thank you so much for this great repository. I compiled neatvi with default settings. But i realized that farsi characters shaping only works in st terminal emulator. I've tested with tilda, tilix, xfce4-terminal. But shaping characters failed in all of them.

First, please check if the font used by these terminals has Farsi glyphs (DejaVuSansMono would be fine, for instance). Also, some terminals reorder and shape right-to-left text automatically. If so, please disable that in the terminal (that is a bad idea anyway). If you can't find the option, in Neatvi you can use the following command to disable letter shaping: :set noshape and if that did not fix it, disable reordering characters: :set noorder Please report the outcome. Ali

[LinArcX]

I've changed font to DejaVuSansMono and also set those options. Tested again, But still get same results.

Actually I don't have any idea about:
disabling reorder and shape right-to-left text in emulators that automatically do it as default behavior.

Those emulators uses vte. Is this the root of problems?

[aligrudi]

LinArcX <[email protected]> wrote:

I've changed to DejaVuSansMono and also set those options. Tested again, But still get same results. Actually I don't have any idea about __disabling reorder and shape right-to-left text in emulators that automatically do it as default behavior__.

Thanks for testing. Please send a screenshot. Ali

[wolandark]

Hi,
Just commenting to say thanks for the great work and that Persian looks fine in NeatVi using Xterm and SourceCodePro Nerd font (also works with unpatched SourceCodePro font).

In xfce4-terminal however, the letters are completely unreadable. This is strange since it's usually the opposite in other CLI programs.

I'll provide a screenshot as reference.

xterm on the left and xfce4-terminal on the right.

If anyone is interested, here is a gist of my ~/.Xresources.

The only issue here is that non-breaking spaces U+00A0 are rendered as -.

As a visual reference, this is the correct look of a word that includes non-breaking space (نیم فاصله):
می‌تواند
The current form in NeatVi:
می-تواند
Let me know if I can run more test for you.

[aligrudi]

Hi, wolandark ***@***.***> wrote:

Just commenting to say thanks for the great work and that Persian looks fine in NeatVi using Xterm and SourceCodePro Nerd font (also works with unpatched SourceCodePro font).

Good to hear that.

In xfce4-terminal however, the letters are completely unreadable. This is strange since it's usually the opposite in other CLI programs. I'll provide a screenshot as reference.  xterm on the left and xfce4-terminal on the right.

Please try defining LNPREF as noted in conf.h ("\33[8l"); this is necessary for vte-based terminals; this paragraph is from the README: Sadly, VTE-based terminals such as GNOME's implement a backward-incompatible extension of virtual terminal escape codes to render bidirectional text by default. When using these terminal, the value of LNPREF macro in conf.h needs to be edited.

If anyone is interested, [here](https://gist.github.com/wolandark/2dc4199ad3cbcd9a111d6767c1ffcb55) is a gist of my `~/.Xresources`. The only issue here is that non-breaking spaces `U+00A0` are rendered as `-`.

That is intentional but can be changed: see the placeholders[] array in conf.h. For non-printable characters, you can define placeholders here. The first entry is for ZWNJ.

As a visual reference, this is the correct look of a word that includes non-breaking space (نیم فاصله): می‌تواند The current form in NeatVi: می-تواند Let me know if I can run more test for you.

Please report if there are any problems. Ali

[wolandark]

Thank you. I should've paid more attention to the README.
Everything worked fine according to your instructions.
Changing {"<200c>", "-", 1}, to {"<200c>", NULL, 1}, allows for correct rendition of the zero-width non-joiner characters.
The bidi problem is also solved in xfce4-terminal after editing the value of the LNPREF macro.
Thanks again.

[aligrudi]

wolandark ***@***.***> wrote:

Thank you. I should've paid more attention to the README. Everything worked fine according to your instructions. Changing `{"<200c>", "-", 1},` to `{"", NULL, 1},` allows for correct rendition of the zero-width non-joiner characters.

This does not seem correct. I suggest something like this (the first entry specifies the character and the second its replacement): {"‌", "", 0}, Ali

[lobre]

@LinArcX / @wolandark, should we consider this issue as tackled? If so, do you think you can close it? Thank you a lot.

[wolandark]

@lobre Yes I believe we can close this issue.

[lobre]

Hopefully @LinArcX can do this, otherwise nobody can 😅