Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly state the features of a contract for a more fair comparison #9

Open
alephao opened this issue May 20, 2022 · 1 comment
Open

Comments

@alephao
Copy link
Owner

alephao commented May 20, 2022

Many of the contracts here have some extra functionality, for example if we look at the ERC20s, Solmate and Maple implements ERC-2612 permits, while the basic OZ's ERC20 doesn't.

Comparing Solmate vs Maple is fair, but OZ vs Solmate is not.

I think it might be a good idea to categorize them somehow, current idea is:

On READMES

Provide a table with features. Example for ERC20:

Contract/Features ERC2612 Another Feature
Solmate
Maple
OZ
OZ with Permit

On JSON

ERC20
  Solmate
    features: [ERC2612]
  Maple
    features: [ERC2612]
  OZ:
    features: []

ERC721
  OZ:
    features: []
  A
    features: [Enumerable]
  OZEnumerable
    features: [Enumerable]

(sorry for being lazy and not writing json by hand, but you got the idea)

@alephao alephao changed the title explicitly state the features of a contract fore a more fair comparison explicitly state the features of a contract for a more fair comparison May 20, 2022
@lucas-manuel
Copy link

I think the tables the easiest to refer to/understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants