Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version of espHome #12

Open
noxqs opened this issue May 7, 2021 · 3 comments · May be fixed by #13
Open

version of espHome #12

noxqs opened this issue May 7, 2021 · 3 comments · May be fixed by #13

Comments

@noxqs
Copy link

noxqs commented May 7, 2021

It is worth noting the required version of espHome is 1.16.2 due to the color.to_rgb_565 requirement.
Both dev and latest have this removed.

@IceSocket
Copy link

IceSocket commented May 12, 2021

This makes the ESPHome Water Leak Sensor un-compilable in Home Assistant.

src/esphome/components/st7735/st7735.cpp: In member function 'virtual void esphome::st7735::ST7735::draw_absolute_pixel_internal(int, int, esphome::Color)': src/esphome/components/st7735/st7735.cpp:275:25: error: 'struct esphome::Color' has no member named 'to_rgb_565' auto color565 = color.to_rgb_565(); ^ *** [/data/water_leak_01/.pioenvs/water_leak_01/src/esphome/components/st7735/st7735.cpp.o] Error 1 ========================== [FAILED] Took 5.49 seconds ==========================

@crowbarz
Copy link

I tried to fix this in #13 by updating the color.to_rgb_565() call per esphome/esphome#1551.

It turns out though that the m5stickC plus that I have uses a st7789v2 screen and not a st7735, so I can't actually test the PR.

@crowbarz crowbarz linked a pull request May 26, 2021 that will close this issue
@IceSocket
Copy link

Confirming fix working for original M5StickC also. Great work, big thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants