Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add birthdate attribute for users #194

Closed
ibot3 opened this issue Aug 8, 2018 · 7 comments
Closed

Add birthdate attribute for users #194

ibot3 opened this issue Aug 8, 2018 · 7 comments
Assignees
Labels
feature 🔨 web/ui Things relating to Flask routes and Jinja templates

Comments

@ibot3
Copy link
Member

ibot3 commented Aug 8, 2018

Every user needs a birthdate attribute. This has to be added to the model.
Methods for editing the birthday for a user need to be implemented in the UI.

@lukasjuhrich
Copy link
Collaborator

Since when is this important? Doesn't this violate the principle of data economy?

@MarauderXtreme
Copy link
Member

It is necessary for providing the network access under current regulations iirc.

@ibot3
Copy link
Member Author

ibot3 commented Aug 8, 2018

https://www.gesetze-im-internet.de/tkg_2004/__111.html

The birthdate of a user is currently stored on papers that wait to be destroyed. But this can only happen after we transferred the dates of birth into our user management system.

@ibot3 ibot3 changed the title Add birthday column for user Add birthdate column for user Aug 8, 2018
@ibot3 ibot3 changed the title Add birthdate column for user Add birthdate attribute to user Aug 8, 2018
@ibot3 ibot3 changed the title Add birthdate attribute to user Add birthdate attribute for users Aug 8, 2018
@toothstone
Copy link
Contributor

toothstone commented Aug 8, 2018

Every user needs a birthdate attribute.

Please note that this only applies to users with network access. A member doesn't need to supply a birthday, only if they apply for a network connection it needs to be recorded (as is done on our forms already).

@lukasjuhrich
Copy link
Collaborator

Please note that this only applies to users with network access.

Ergo:

  1. Make the column nullable
  2. incorporate the optionality in the UI-workflow (e.g. if there were optional forms for people requesting network access and other people, one form should require the birthday, another should not)

@ibot3 ibot3 added feature 🔨 web/ui Things relating to Flask routes and Jinja templates labels Aug 9, 2018
@toothstone
Copy link
Contributor

Given the recent GDPR troubles, we probably should implement TKG § 111(5) as well:

(5) Die Daten nach den Absätzen 1 und 2 sind mit Ablauf des auf die Beendigung des Vertragsverhältnisses folgenden Kalenderjahres zu löschen.

Or we will have to set up a workflow to do that manually for Pycroft.
But I guess cleanup routines by now merit their own bundle of issues anyhow...

@lukasjuhrich
Copy link
Collaborator

@toothstone #67 is related

@ibot3 ibot3 self-assigned this Aug 14, 2018
@ibot3 ibot3 closed this as completed in b6b219e Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🔨 web/ui Things relating to Flask routes and Jinja templates
Projects
None yet
Development

No branches or pull requests

4 participants