Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x installation can't be finished #1818

Closed
mmaslano opened this issue Dec 6, 2024 · 8 comments
Closed

s390x installation can't be finished #1818

mmaslano opened this issue Dec 6, 2024 · 8 comments

Comments

@mmaslano
Copy link

mmaslano commented Dec 6, 2024

I tried to install agama-installer.s390x-10.0.0-SLE-Alpha2.iso, which failed to boot after the installation. But it was possible to pick dasd disk, activate, format and storage management was happy. I didn't setup partitions and used default.

With agama-installer.s390x-10.0.0-SLE-Build38.1.iso I'm unable to finish the installation because of the storage. I activated dasd, formatted, but I still see "Storage proposal not possible". I disabled btrfs snapshots, sadly I was unable to change partitions fs from btrfs to xfs for /. It looks like it's not possible to delete / and start over and edit doesn't help.

I'm attaching logs, but I doubt it's helpful. Maybe the right button is there, but I can't find it, which will be also a problem for customers.

agama-logs-1733517061.tar.gz

@kobliha
Copy link
Contributor

kobliha commented Dec 6, 2024

Maybe related to #1758

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

The problem has nothing to do with Btrfs vs XFS or with enabling/disabling snapshots.

Storage cannot make a proposal because there is no disk considered as a valid candidate. I will investigate why.

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

Reading the logs...

After activating the DASD, a so-called storage reprobing is performed and dasda is considered as an acceptable disk:

y2storage/disk_analyzer.rb(candidate_disks):142 Found candidate disks: [<Dasd /dev/dasda 21600000 KiB (20.60 GiB)>]

But then Agama makes a new proposal and seems to ignore that disk for some reason I would need to investigate:

y2storage/guided_proposal.rb(try_with_target):179 Trying to make a proposal
using the following settings:
root_device:
candidate_devices: [""]

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

@mmaslano What do you see if you click on the button to change the installation device after having formatted the DASD?

I mean this button underlined in red.

change

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

@mmaslano Gave me access to the machine and I reproduced the bug. The problem is that, after performing the DASD operations, Agama tries to update the list of installation issues. But that process is failing because storage_manager.proposal is nil when this line is executed:

https://github.com/agama-project/agama/blob/master/service/lib/agama/storage/proposal_strategies/guided.rb#L65

Everything goes downhill from there.

I will commit a fix.

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

#1822 implements a workaround. The root of the issue is not fixed, but the failing code path will disappear in a couple of months when the new storage proposal is finished.

I will keep the issue open to make sure we test this scenario with the new storage proposal.

@ancorgs
Copy link
Contributor

ancorgs commented Dec 9, 2024

Trello card (private SUSE link): https://trello.com/c/hv9UCWm0/726-s390x-installation-cannot-be-finished

ancorgs added a commit that referenced this issue Dec 9, 2024
## Problem

As described at #1818, there seems to be a problem when installing at
s390x and starting with no available disks. See [this
comment](#1818 (comment))
at the original issue.

After visiting the DASD section and activating+formatting a device, the
backend fails and the UI becomes barely usable.

The error is produced when checking `storage_manager.proposal` after
re-probing the system and trying an (unsuccessful) proposal.

## Solution

This pull request does not implement a real fix, but a workaround that
has proven to be useful in that case. It allowed the installation to
continue successfully at the reported scenario.

I tried to fix the real root of the issue, but I was unable to find out
why `storage_manager.proposal` was nil at that point.

But since we are rewriting the approach to the storage proposal, the
whole `ProposalStrategies::Guided` class is going to disappear so it
makes little sense to invest more time.

I will keep the original issue open and will create a Trello card to
track it, so we check whether the new implementation of the storage
proposal (still under development) is reliable in that situation.

## Testing

Verified with manual testing. Going further would be wasting resources
right now.
@ancorgs
Copy link
Contributor

ancorgs commented Dec 19, 2024

Fixed by the mentioned workaround #1822

@ancorgs ancorgs closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants