Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py weird format, slower #3

Open
HDembinski opened this issue Jun 8, 2018 · 1 comment
Open

setup.py weird format, slower #3

HDembinski opened this issue Jun 8, 2018 · 1 comment

Comments

@HDembinski
Copy link
Contributor

setup.py has a weird format, that is highly non-standard for a setup.py.

  1. One does not use if __name__ == "__main__" in setup.py, because it is never imported as a module. It is always executed as a script.

  2. Constructing the arguments to setup(...) separately in a dict is slower than just passing the arguments directly to setup(...). There is no advantage in doing it the way you do.

@afedynitch
Copy link
Owner

Hi Hans,

sorry, I've noticed this now :)

I'm doing this for the version argument to be importable in docs/conf.py, without importing anything else that requires the execution of setup.py. The intention is to keep the version number in setup.py and docs synchronized. I'm happy to change this to anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants