You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The rationale of this issue is initially to remove a redirection to a specific client since this project is open-source. I'd like the client to redirect to itself (not myecl.fr specifically) when logging in successfully, and that the redirection works as intended.
After multiple failed attempts, here's what I noticed:
For Titan specifically, the redirection doesn't redirect as a watchful user would expect. E.g. when logging in on the alpha website, the small window closes after loading https://myecl.fr/static.html so that in practice you're still on the alpha web, although a watchful user would've noticed the redirect URI was actually set to the prod website.
However, when changing "myecl.fr" to "example.org" above (L122) AND using https://example.org/static.html in Hyperion's .env, the window redirects perfectly but is NOT closed afterwards.
This fact that the window to Hyperion is closed by Titan after loading https://myecl.fr/static.html appears to me as a security issue: someone could create a malicous website which redirects to our SSO with https://myecl.fr/static.html as redirect URI then close the window and be back on the malicious website because Hyperion saw https://myecl.fr/static.html and a structure compatible with AppAuthClient. Perhaps this is impossible given that we can't even have the prod flavor to work (the prod Hyperion does not recognize my local client).
For reference, see #146 and Hyperion#212 about security and overdependence on our infrastructure.
Steps to reproduce
On a computer:
The text was updated successfully, but these errors were encountered: