Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate adoptium-packages-linux into Jenkins build pipelines #84

Closed
smlambert opened this issue Mar 5, 2021 · 10 comments
Closed

Incorporate adoptium-packages-linux into Jenkins build pipelines #84

smlambert opened this issue Mar 5, 2021 · 10 comments
Assignees
Labels
enhancement installer Issues that relate to our installer jobs or installer repo linux new builds Issues that request for new jenkins pipeline builds testing

Comments

@smlambert
Copy link
Contributor

This is a placeholder issue for initial incorporation of the adoptium-packages-linux work, based on the what @aahlenst has in https://github.com/aahlenst/adoptium-packages-linux. We would now like to be able to trigger build and test of these linux packages from Jenkins build pipelines.

As to where this gets triggered, see the diagram found in AdoptOpenJDK/TSC#158 (comment), upon the creation of the JDK binaries, the installer pipeline can be triggered.

Initial objective is to get building and testing of these packages running. https://github.com/aahlenst/adoptium-packages-linux/blob/main/NOTES.txt has some notes. This issue can (and should) encompass some remodelling effort to get rid of the large number of jobs. It should also be standalone/modular enough to restart if failed (without a complete rerun of build pipelines / like test pipelines). We can assume that this work will go through several iterations before its refined, but let's get some basic pipeline in place and then work on refinements.

Some further steps (which can be captured under a separate issue) can be to see whether we can publish into https://cloudsmith.com/ before adding more versions, more packages.

@M-Davies M-Davies added installer Issues that relate to our installer jobs or installer repo new builds Issues that request for new jenkins pipeline builds labels Mar 5, 2021
@github-actions github-actions bot added the linux label Mar 20, 2021
@smlambert
Copy link
Contributor Author

I'll book time for a quick discussion on the initial approach with @sophia-guo and @aahlenst (likely Friday).

@sophia-guo
Copy link
Contributor

Initial draft https://github.com/sophia-guo/ci-jenkins-pipelines/tree/installer working with jenkins build https://ci.adoptopenjdk.net/view/work-in-progress/job/adoptium-packages-linux/. There are some details need to be clarified. We will talk on Friday's meeting.

@aahlenst
Copy link
Contributor

Thanks a lot, @sophia-guo. Do I see correctly that it's now part of the normal openjdk-build pipeline? I guess this makes things more complicated than needed because the packages do not depend on the openjdk-build pipelines (same as Docker). They are completely independent and on their own schedule. We will also have packages without a corresponding openjdk-build job (think IBM SDK).

@smlambert
Copy link
Contributor Author

That may be my misrepresenting the requirements to @sophia-guo ... which is also why to connect with you Friday @aahlenst. I understood that you wanted to incorporate this into the build pipelines. Even easier should that not be the case. Talk with you soon on the topic.

@karianna
Copy link
Contributor

karianna commented Mar 28, 2021

I'm late for the party here :-). Is this intended to replace the existing openjdk-installer based steps we have for producing Linux Packages, or is this something else?

@smlambert
Copy link
Contributor Author

We are going to move the Jenkins changes that are currently in @sophia-guo's branch out of this repo and into https://github.com/aahlenst/adoptium-packages-linux so that the 'new' way of building installers can be standalone.

The nice thing about the adoptium-packages-linux repo is that it contains testing for installers (via TestContainers). I believe it will eventually replace the existing openjdk-installer work, but there is more to do before we would reach that point.

@aahlenst
Copy link
Contributor

Is this intended to replace the existing openjdk-installer based steps we have for producing Linux Packages.

Yes. The old code won't see any further development from me. I haven't officially deprecated it yet, because the new one isn't ready. I haven't created my intro write-up for the community discussion, either.

llxia pushed a commit to llxia/ci-jenkins-pipelines that referenced this issue Aug 23, 2022
Enable FIPS testing for JDK8
@zdtsw
Copy link
Contributor

zdtsw commented Sep 15, 2022

is this still a valid issue? or has it done

@karianna
Copy link
Contributor

Still to be done (in terms of full automation)

@smlambert
Copy link
Contributor Author

Closing this in favour of the installer overhaul being done under adoptium/installer#1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement installer Issues that relate to our installer jobs or installer repo linux new builds Issues that request for new jenkins pipeline builds testing
Projects
None yet
Development

No branches or pull requests

6 participants