Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex in disable impl #568

Open
llxia opened this issue Jun 7, 2024 · 2 comments
Open

Support regex in disable impl #568

llxia opened this issue Jun 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@llxia
Copy link
Contributor

llxia commented Jun 7, 2024

Currently, TKG does the exact match in disable. If we need to exclude 2 impls, we need to write 2 <disable> separately . See https://github.com/adoptium/aqa-tests/blob/0f1508971ddb416332fdf96de93fd9c1a9f4dfc3/openjdk/playlist.xml#L1380-L1389

It would be nice if we could support regex in disable impl. The above can be specified in one <disable>.

<disable>
		<comment>issue link</comment>
		<impl>openj9|ibm</impl>
</disable>
@llxia llxia added the enhancement New feature or request label Jun 7, 2024
@IamLRBA
Copy link
Contributor

IamLRBA commented Nov 27, 2024

Hello @llxia , may i be assigned this issue please.
Thanks!

@smlambert
Copy link
Contributor

smlambert commented Nov 27, 2024

@IamLRBA - if this is your first issue in this project, I suggest you select from the ones marked as 'good first issues' as a warm-up and to ensure you have created an Eclipse profile and signed the ECA (details here), then graduate to these issues that are more involved feature enhancements as you become more familiar with the code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants