Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Research](Toast): Deprecated variant types #4931

Open
1 task done
caseyisonit opened this issue Nov 11, 2024 · 0 comments
Open
1 task done

[Research](Toast): Deprecated variant types #4931

caseyisonit opened this issue Nov 11, 2024 · 0 comments

Comments

@caseyisonit
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Description of issue

In Toast.ts, the variants error, warning, and success have //deprecated next to them but they are not marked or documented for deprecation anywhere else in the code.

Resolution:

  • if not deprecated, clean up the comments
  • if deprecated, properly mark the variant types as deprecate and documented in our args tables across all documentation sites with a date of decrecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants