Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breadcrumbs]: package name is inconsistent #1534

Open
GarthDB opened this issue Oct 20, 2022 · 3 comments
Open

[Breadcrumbs]: package name is inconsistent #1534

GarthDB opened this issue Oct 20, 2022 · 3 comments
Assignees
@pfulton @castastrophe @najikahalsema
Labels
bug Results from a bug in the CSS implementation jira ticket created question Further information is requested

Comments

@GarthDB
Copy link
Member

GarthDB commented Oct 20, 2022

Description

Breadcrumbs:

Breadcrumb:

I would recommend changing it to breadcrumbs as that follows the design system website and fits with similar patterns like tabs.
@GarthDB GarthDB added bug Results from a bug in the CSS implementation Component: Breadcrumbs labels Oct 20, 2022
@GarthDB
Copy link
Member Author

GarthDB commented Oct 20, 2022

The annoying part of renaming it would be a brand new package and deprecating the old package for just a single letter.

@Deanna-w1 Deanna-w1 changed the title Breadcumbs name is inconsistent Breadcrumbs name is inconsistent Jan 25, 2023
@castastrophe
Copy link
Collaborator

Hmm the classname is Breadcrumbs with an S too. @pfulton what would you think of a package rename?

@castastrophe castastrophe added the question Further information is requested label Mar 6, 2023
@castastrophe castastrophe changed the title Breadcrumbs name is inconsistent [Breadcrumbs]: package name is inconsistent Mar 6, 2023
@castastrophe castastrophe self-assigned this Dec 10, 2024
@castastrophe castastrophe added the sync to jira These will be pushed into adobe internal jira label Dec 10, 2024
@castastrophe
Copy link
Collaborator

The ask here is to deprecate @spectrum-css/breadcrumb and publish: @spectrum-css/breadcrumbs.

@najikahalsema najikahalsema added jira ticket created and removed sync to jira These will be pushed into adobe internal jira labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfulton pfulton

@castastrophe castastrophe

@najikahalsema najikahalsema

Labels
bug Results from a bug in the CSS implementation jira ticket created question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GarthDB @pfulton @castastrophe @najikahalsema