Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ~/.wskprop reading code from aio-cli-plugin-runtime #699

Open
purplecabbage opened this issue Dec 7, 2024 · 2 comments
Open

Remove ~/.wskprop reading code from aio-cli-plugin-runtime #699

purplecabbage opened this issue Dec 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

If the plugin fails to find values in a bunch of other places it goes all the way to ~/.wskprops for values, mine were junk so I was super confused why everything seemed to break with the runtime command.

We will never go back to having a single global namespace / api-host etc. so we can safely remove this and prevent future mes from having the same issue.

Environment Info

  System:
    OS: macOS 15.1.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.70 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.10.0 - ~/.nvm/versions/node/v22.10.0/bin/node
    Yarn: 1.22.19 - ~/.bun/bin/yarn
    npm: 10.9.0 - ~/.nvm/versions/node/v22.10.0/bin/npm
  Virtualization:
    Docker: 20.10.17 - /usr/local/bin/docker
  npmGlobalPackages:
    @adobe/aio-cli: 10.3.1

Sample Code that illustrates the problem

Logs taken while reproducing problem

@purplecabbage purplecabbage added the bug Something isn't working label Dec 7, 2024
@shazron
Copy link
Member

shazron commented Dec 7, 2024

I'm fine with this as long as we bump the major version and document of course

@aiojbot
Copy link

aiojbot commented Dec 7, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants