Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultReplicationAgents rule doesn't normalize replication target URIs #34

Open
actinium15 opened this issue May 26, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@actinium15
Copy link

at [0], DefaultReplicationAgents configures the replication agents with supplied serverUrl + /bin/receive as transport URI.
However, since the serverUrl may have a trailing character, [0] should normalize the replication target URI before updating the replication agent config to avoid double slashes in the target URI.

[0] https://github.com/adobe/aem-testing-clients/blob/cq-65/src/main/java/com/adobe/cq/testing/junit/rules/DefaultReplicationAgents.java#L103

@dulvac dulvac self-assigned this May 26, 2020
@dulvac dulvac added the bug Something isn't working label May 26, 2020
@mohiaror
Copy link

@dulvac, @actinium15 We are still facing this issue in assets' nightly job when the requests to publish are intermittently failing when the URL contains double slash. Can this issue be prioritized?

@actinium15
Copy link
Author

We are still facing this issue in nightly job when the requests to publish are intermittently failing when the URL contains double slash.

Hi @mohiaror, I wouldn't expect this issue to appear intermittently if the URLs contain double slashes - it should appear consistently for all urls with double slashes. Can you please reconfirm the statu?
Also, I recall this being fixed within AEM since the time this particular github issue was opened. Can you please confirm if AEM is able to process requests with double slashes or not (perhaps using curl)?

@mohiaror
Copy link

mohiaror commented Dec 1, 2020

@actinium15

I wouldn't expect this issue to appear intermittently if the URLs contain double slashes - it should appear consistently for all urls with double slashes. Can you please reconfirm the statu?

Yes, I can see double slashes even in the logs of the jobs which are successful.

Also, I recall this being fixed within AEM since the time this particular github issue was opened. Can you please confirm if AEM is able to process requests with double slashes or not (perhaps using curl)

It seems this is where the intermittent behavior is observed. Sometimes the requests are correctly processed and sometimes they throw error. I will investigate more and log an AEM issue for this.

But would you guys suggest that this issue should also be fixed in the meanwhile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants