Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower package too please #181

Open
dkebler opened this issue Aug 5, 2015 · 6 comments
Open

bower package too please #181

dkebler opened this issue Aug 5, 2015 · 6 comments

Comments

@dkebler
Copy link

dkebler commented Aug 5, 2015

Can I talk you into publishing a bower package of your repo as well.

It's as simple as adding a bower.json file to your repo with a "main" designation to the scss file(s) that should be @import-ed and then registering your repo with bower. Once set up it updates automagically with pushes to your github repo. http://bower.io/docs/creating-packages/.

My gulp based workflow is set up to have scss libraries I make use of (like kickstart) as bower packages. I've written code to grab all the scss paths from bower packages and set them to a loadpaths variable for use with node-sass and then off course it's easy to keep all the bower packages up to date with gulp. This works much better for me than sass libraries as npm packages.

The more ways to easily include Kickstart the better no?

@adamjgrant
Copy link
Owner

Sure. I'll see what I can do. I'd like to actually transition to bower for extensions as well. Git submodules have proven cumbersome. Please hold.

@adamjgrant
Copy link
Owner

Done. Registered as kickstart_bower. That being said, I have done 0 testing with it.

@dkebler
Copy link
Author

dkebler commented Aug 6, 2015

Thanks.

You still need to add "main" to bower.json.
and too I don't see a single partial that imports the rest that could be
your "main"

but......now that I root around in the kickstart/lib-core/sass/ I see
that your sass is indented not scss.
Rats.. node-sass (libass) can't handle both syntax within a single
compile. It's one or the other. I write everything in scss and have been
avoiding (maybe great) sass indent libraries for this reason.

So what was just a simple request is now more major, like converting sass
to scss.
There are converters although I don't know how readable the converted sass
would be?
I could pipe your sass through npm package sass-convert.
https://www.npmjs.com/package/sass-convert
but that involves loading ruby-sass, and I specifically have avoided ruby
and thus ruby-sass and use the much faster libsass.

I could do a convert, but if you are hooked on indent sytle for the future
might be hassle down the road with updates and conversions.
If you need some convincing The "God of Sass", Hugo Giraudel, has gone the
scss route, http://sass-guidelin.es/#sass-or-scss and
http://josephrex.me/moving-from-indented-sass-to-scss/

What to do?


{
  "name": "kickstart",
  "version": "3.1.1",
  "homepage": "https://github.com/adamjgrant/kickstart",
  "authors": [
    "Adam Grant <[email protected]>"
  ],
  "description": "The CSS Library that Loves to Be Extended",
  "license": "MIT",
  "main": [
    "path/to/partial/that/imports/others/kickstart.scss"
    ],
   "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test",
    "tests"
  ]
 }

On Wed, Aug 5, 2015 at 2:41 PM, Adam Grant [email protected] wrote:

Done. Registered as kickstart_bower. That being said, I have done 0
testing with it.


Reply to this email directly or view it on GitHub
#181 (comment)
.

Cheers, Cuidate, TTFN http://www.youtube.com/watch?v=5Gu50vq5ux4
David

@dkebler
Copy link
Author

dkebler commented Aug 12, 2015

So I was wrong. It turns out the libsass can now automatically
parse/compile both scss and indented sass files together as long as they
use their respective extensions so there is no need to heed my suggestion
of a conversion to scss syntax.

Given that I want to use Kickstart so

I just sent you a PR with a _kickstart.sass file that imports all your core
files and then added that to a main entry in the bower.json file.
That's what is need to use all your sass core.


So now that I can compile it is throwing an error in some files with this.
Message: unbound variable $space
I will open a separate issue for this

Also I'll need bower access to your concatenated kickstart.js and which
means taking out those files from your gitignore.

I'll do a separate issue for that as well to make it easier to track.

On Wed, Aug 5, 2015 at 6:35 PM, David Kebler [email protected] wrote:

Thanks.

You still need to add "main" to bower.json.
and too I don't see a single partial that imports the rest that could be
your "main"

but......now that I root around in the kickstart/lib-core/sass/ I see
that your sass is indented not scss.
Rats.. node-sass (libass) can't handle both syntax within a single
compile. It's one or the other. I write everything in scss and have been
avoiding (maybe great) sass indent libraries for this reason.

So what was just a simple request is now more major, like converting sass
to scss.
There are converters although I don't know how readable the converted sass
would be?
I could pipe your sass through npm package sass-convert.
https://www.npmjs.com/package/sass-convert
but that involves loading ruby-sass, and I specifically have avoided ruby
and thus ruby-sass and use the much faster libsass.

I could do a convert, but if you are hooked on indent sytle for the future
might be hassle down the road with updates and conversions.
If you need some convincing The "God of Sass", Hugo Giraudel, has gone the
scss route, http://sass-guidelin.es/#sass-or-scss and
http://josephrex.me/moving-from-indented-sass-to-scss/

What to do?


{
  "name": "kickstart",
  "version": "3.1.1",
  "homepage": "https://github.com/adamjgrant/kickstart",
  "authors": [
    "Adam Grant <[email protected]>"
  ],
  "description": "The CSS Library that Loves to Be Extended",
  "license": "MIT",
  "main": [
    "path/to/partial/that/imports/others/kickstart.scss"
    ],
   "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test",
    "tests"
  ]
 }

On Wed, Aug 5, 2015 at 2:41 PM, Adam Grant [email protected]
wrote:

Done. Registered as kickstart_bower. That being said, I have done 0
testing with it.


Reply to this email directly or view it on GitHub
#181 (comment)
.

Cheers, Cuidate, TTFN http://www.youtube.com/watch?v=5Gu50vq5ux4
David

Cheers, Cuidate, TTFN http://www.youtube.com/watch?v=5Gu50vq5ux4
David

@hurrycaner
Copy link

+1 bower support 👍

@adamjgrant
Copy link
Owner

Thanks folks. Planning for a wedding at the moment, but I can definitely see the need for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants