Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass::SyntaxError Undefined variable: "$breakpoint-1px". #179

Open
ccastillop opened this issue Jun 1, 2015 · 4 comments
Open

Sass::SyntaxError Undefined variable: "$breakpoint-1px". #179

ccastillop opened this issue Jun 1, 2015 · 4 comments

Comments

@ccastillop
Copy link

After using st like:

.main-nav {
  @include navbar($layout: 'fluid-fixed');
}

pops up Sass::SyntaxError Undefined variable: "$breakpoint-1px".

Instead, using st like:

.main-nav {
  @include navbar();
}

works fine.

Rails 4.2.0, kickstart_rails (3.1.2), sass (3.4.14)

@adamjgrant
Copy link
Owner

Thanks for reporting this. But I don't seen any difference between the two code blocks. What was the code that worked?

@ccastillop
Copy link
Author

Sorry the mistake. I've just corrected the bug.
Adding $layout: 'fluid-fixed' or $background-color: #333 rises the error. Without arguments navbar() works fine.

@ccastillop
Copy link
Author

Ok,
Browsing the code I found this line: /lib-core/sass/core/components/_navbar.sass#L26 similar to $breakpoint - 1px. Notice the white space between -.

Browsing locally the gem kickstart_rails-3.1.2 I notice this line very similar but without the white spaces: ~/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/kickstart_rails-3.1.2/app/assets/stylesheets/core/components/_navbar.sass Line 26

> li
  ul[role=button], > [role=button], &.navbar-title button[role="button"]
    @media screen and (max-width: #{$breakpoint-1px})
      margin:
        left: 0
        right: 0

Adding manually the white spaces works. Why these spaces were removed?

@adamjgrant
Copy link
Owner

Good find! Yes, it definitely looks like this was fixed in the main repo,
but wasn't pushed into the rails gem. I'm mobile at the moment so I can't
fix this just yet, but I'll make sure this is taken care of as soon as I
can.
Le Mon, Jun 1, 2015 à 11:29 AM, Cristiam Castillo [email protected]
a écrit :

Ok,
Browsing the code I found this line:
/lib-core/sass/core/components/_navbar.sass#L26 similar to $breakpoint -
1px. Notice the white space between -.

Browsing locally the gem kickstart_rails-3.1.2 I notice this line very
similar but without the white spaces:
~/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/kickstart_rails-3.1.2/app/assets/stylesheets/core/components/_navbar.sass
Line 26

li
ul[role=button], > [role=button], &.navbar-title button[role="button"]
@media screen and (max-width: #{$breakpoint-1px})
margin:
left: 0
right: 0

Adding manually the white spaces works. Why these spaces where removed?


Reply to this email directly or view it on GitHub
#179 (comment)
.

Adam Grant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants