New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom proxy functionality #134

Open

gr2m opened this issue May 1, 2024 · 1 comment · May be fixed by #143

Labels

feature

Contributor

gr2m commented May 1, 2024 •

edited

Loading

Looks like Undici added native proxy support, so we may be able to remove the custom proxy support we added in #102.

create-github-app-token/lib/request.js

Lines 15 to 16 in 3cef845

    
           // Native support for proxies in Undici is under consideration: https://github.com/nodejs/undici/issues/1650 
        
           // Until then, we need to use a custom fetch function to add proxy support.

Originally posted by @parkerbxyz in #132 (comment)

gr2m added feature good first issue labels

parkerbxyz linked a pull request

that will close this issue

fix: remove custom proxy handling #143

Draft

parkerbxyz linked a pull request

that will close this issue

fix: remove custom proxy handling #143

Draft

parkerbxyz removed the good first issue label

Contributor

parkerbxyz commented Dec 20, 2024

This depends on nodejs/node#43187. We may need to wait until that is resolved to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment