Acquia Cloud does not support hyphens in db names

[ssu-carlsoni]

drupal-environment-detector/src/FilePaths.php

Line 30 in 782e2b9

$site_name = str_replace('.', '_', $site_name);

[ssu-carlsoni]

While moving to Acquia Recommended Settings we had an issue with one of our multisites with a hyphen in the domain. Example: childrens-school.domain.edu

We addressed in the sites settings.php file via the following

// Acquia Recommended Settings - does not support hyphens in site names
if (EnvironmentDetector::isAhEnv()) {
  $site_settings_file = FilePaths::ahSettingsFile(EnvironmentDetector::getAhGroup(), 'childrens_school');
  if (file_exists($site_settings_file)) {
    require_once $site_settings_file;
  }
}

I think FilePaths::ahSettingsFile should be updated to support this configuration.