Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synology DSM API path regex is wrong #4808

Closed
winromulus opened this issue Sep 25, 2023 · 2 comments
Closed

Synology DSM API path regex is wrong #4808

winromulus opened this issue Sep 25, 2023 · 2 comments

Comments

@winromulus
Copy link
Contributor

Summary: The issue first appeared in this PR due to an invalid regex when looking up the API path.

Steps to reproduce

Try to deploy any certificate to Synology DSM

Debug log

Contains sensitive data. Result is a 404 in curl output.

@github-actions
Copy link

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

@essamm63
Copy link

essamm63 commented Sep 25, 2023

I've found that the issue is that in synology_dsm.sh line 94 is not setting the api_path correctly.

I suspect that the response to the previous query call changed and is now:
{"data":{"SYNO.API.Auth":{"maxVersion":7,"minVersion":1,"path":"entry.cgi"}},"success":true}

Replacing sed regex in line 94 of synology_dsm.sh with a jq expression that works and seems to be more reliable:
api_path=$(echo "$response" | jq -r '.data."SYNO.API.Auth".path')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants