Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputStreamBuffer seems to be vestigial #76

Open
epall opened this issue Nov 26, 2017 · 0 comments
Open

InputStreamBuffer seems to be vestigial #76

epall opened this issue Nov 26, 2017 · 0 comments

Comments

@epall
Copy link
Contributor

epall commented Nov 26, 2017

It appears that io.pkts.buffer.InputStreamBuffer has been replaced by io.pkts.buffer.BoundedInputStreamBuffer in all usage. Given how similar the two classes are, does it make sense to delete the vestigial io.pkts.buffer.InputStreamBuffer? If not, can we extract a superclass to reduce duplication?

I ask because I'm poking around with why my code is slow, and it turns out that Buffer.readBytes(int) calls are forwarded all the way down to a low-level Channel that's really inefficient for short reads, so I want to find some place to buffer a few KB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant